feat(server): label query metrics with dataset#1805
Open
Conversation
Add per-dataset dimension to all query metrics so operators can filter throughput, errors, and latency by dataset in observability dashboards. - Add `catalog_dataset_labels()` to extract unique `namespace/name` labels from the catalog - Add `dataset` parameter to all `MetricsRegistry` recording methods - Emit metrics once per referenced dataset for cross-dataset queries - Label streaming counters (`active`, `started`, `completed`) with dataset key-values Signed-off-by: Leonardo Yvens <leoyvens@gmail.com>
leoyvens
force-pushed
the
leo/label-query-metrics-with-dataset
branch
from
a5a064f to
b772ef0
Compare
Collaborator
Author
|
|
Expose the dataset name without namespace prefix as a dedicated label to simplify metric queries and aggregations that don't need namespace context. - Add `dataset_name` label alongside existing `dataset` (`namespace/name`) on all query metrics - Introduce `dataset_kvs()` helper in `metrics.rs` to centralize both label construction - Refactor metrics methods to accept `&HashReference` instead of `&str` for type safety - Update `catalog_dataset_labels` to return `Vec<HashReference>` instead of `Vec<String>` Signed-off-by: Leonardo Yvens <leoyvens@gmail.com>
leoyvens
force-pushed
the
leo/label-query-metrics-with-dataset
branch
from
80d6b83 to
3585214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dataset label dimension to all query metrics so operators can filter throughput, errors, and latency by dataset in observability dashboards.
Queries may reference multiple datasets, in which case the metric will be updated for each referenced dataset.