refactor(server): Register metrics for peak memory usage#1803
Open
refactor(server): Register metrics for peak memory usage#1803
Conversation
Consolidate memory usage reporting into the metrics recording path instead of relying on a stream wrapper in common. - Remove `PeakMemoryStream` wrapper from `QueryContext` - Expose `memory_pool()` accessor on `QueryContext` - Record peak memory in `record_query_execution` alongside other metrics - Remove unused `record_query_memory` method Signed-off-by: Leonardo Yvens <leoyvens@gmail.com>
leoyvens
force-pushed
the
leo/query-mem-usage-metrics
branch
from
bc36748 to
809d735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric was previously in the dead
fn record_query_memory. Also reimplements #1792, consolidating memory usage reporting into the metrics recording path instead of relying on the funky log on drop.record_query_executionalongside other metricsrecord_query_memorymethod