fix(ampsync): tighten temp table creation#1802
Open
abarmat wants to merge 1 commit intoedgeandnode:mainfrom
Open
fix(ampsync): tighten temp table creation#1802abarmat wants to merge 1 commit intoedgeandnode:mainfrom
abarmat wants to merge 1 commit intoedgeandnode:mainfrom
Conversation
Update temp table creation to include DEFAULTS and ON COMMIT DROP so it stays within transaction scope, and add a regression test that verifies the generated SQL contains the expected clauses.
abarmat
force-pushed
the
fix/ampsync-tmp-tables-oom
branch
from
e0a1ee5 to
d5a7065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update temp table creation to include DEFAULTS and ON COMMIT DROP so it stays within transaction scope, and add a regression test that verifies the generated SQL contains the expected clauses.
Close: #1801