feat: Pass oneOf subschema to Translator #2536
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @daniel-shuy, thanks for the contribution ❤️ This definitely makes sense to me. I have one comment inline regarding consistency with existing passing of schemas to the translator. Please have a look :)
| // prefer schema keys as they can be more specialized | ||
| if (e.i18n) { | ||
| label = t(e.i18n, label); | ||
| label = t(e.i18n, label, e); |
Contributor
There was a problem hiding this comment.
Looking at the control mapper, the schema is passed in an object. I think this would be preferable for consistency reasons. I.e. { schema: e }. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translating oneOf, pass the subschema to the
Translatorto be consistent with otherTranslatorcalls so that theTranslatorcan access the subschema