generated from eclipse-score/module_template
-
Notifications
You must be signed in to change notification settings - Fork 8
Adds dep to logging module #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmaddikery
wants to merge
5
commits into
eclipse-score:main
Choose a base branch
from
rmaddikery:rama_mw_log_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+25
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
- cc-binary require dep to logging for providing a logging backend
- So that these module deps not propagate to other users of this module.
01659ac to
271cdda
Compare
|
The created documentation from the pull request is available at: docu-html |
antonkri
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dep to logging module
- cc-binary needs to provide a logging backend.
- Removes deprecated feature flags for mw/log
- Required for fixing issues in reference_integration of datarouter
Ref:
/external/rules_go+/go/private/extensions.bzl:287:21: Traceback (most recent call last):
File ".cache/bazel/_bazel_q541813/ba8a5ccfd9c81f6be3c399861077e8b5/external/rules_go+/go/private/extensions.bzl", line 287, column 21, in _go_sdk_impl
fail("go_sdk.download: name must not be specified in non-root module " + module.name)
Error in fail: go_sdk.download: name must not be specified in non-root module score_scrample
ERROR: Analysis of target '//build:init' failed; build aborted: error evaluating module extension @@rules_go+//go:extensions.bzl%go_sdk