Skip to content

Conversation

@iloveeclipse
Copy link
Member

Avoids endless resize operations & UI hangs in case resize listener/handler code itself triggers some OS specific resize events.

Fixes #3676

Avoids endless resize operations & UI hangs in case resize
listener/handler code itself triggers some OS specific resize events.

Fixes eclipse-platform#3676
@iloveeclipse
Copy link
Member Author

@HeikoKlare : I can't reproduce on Linux, so it looks like it is Windows specific. Could you please check if you can reproduce?

public class TableResizeHelper {

private final TableViewer tableViewer;
boolean resizeInProgress;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package protected to avoid extra synthetic accessor method being generated

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From ba724328bf78ef7f73d071389976ffa11503eb17 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 15 Jan 2026 14:13:43 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF b/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
index a45f16b13a..43dd271953 100644
--- a/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.text.quicksearch;singleton:=true
-Bundle-Version: 1.3.300.qualifier
+Bundle-Version: 1.3.400.qualifier
 Bundle-Activator: org.eclipse.text.quicksearch.internal.ui.QuickSearchActivator
 Require-Bundle: org.eclipse.ui;bundle-version="[3.113.0,4.0.0)",
  org.eclipse.core.resources;bundle-version="[3.13.0,4.0.0)",
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 23m 13s ⏱️ + 5m 18s
 8 270 tests ±0   8 022 ✅ +1  248 💤 ±0  0 ❌  - 1 
23 634 runs  ±0  22 843 ✅ +1  791 💤 ±0  0 ❌  - 1 

Results for commit a3dd2bc. ± Comparison against base commit 647256d.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce on Linux, so it looks like it is Windows specific. Could you please check if you can reproduce?

I tried different setups and inputs, but I was not able to reproduce the originally reported issue. Since the report mentions that the issue is sporadic, it seems not so easy to provoke that situation.
Since we quite some changes to control-sizing-related functionality because of the HiDPI functionality on Windows, I also checked if there might be anything involved here (which might have also been resolved recently), but I didn't find anything related.

Given the information we have from the error stack trace, the proposed solution seems fine to avoid a freeze. Since we don't know why the resize triggered itself repeatedly, there is a slight risk of a side effect/regression by the table potentially not reaching a "stable" resized state. But would still be better than running into a freeze.

@iloveeclipse iloveeclipse merged commit a8b54b3 into eclipse-platform:master Jan 17, 2026
18 checks passed
@iloveeclipse
Copy link
Member Author

Thanks Heiko.

@iloveeclipse iloveeclipse deleted the issue_3676 branch January 17, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Search repeatedly refreshes results and UI becomes “Not Responding” (STS 5/4 - Eclipse)

3 participants