Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Jan 12, 2026

Migrates the tests in from JUnit 4 to JUnit 5.

Changes include:

  • Updating to depend on JUnit 5 packages.
  • Converting imports and annotations in test classes (e.g., , , ).
  • Updating assertions to use .
  • Converting to use .

Tests verified locally.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From dac6016c78f838280ae745073f7153bae5cf0613 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 12 Jan 2026 10:21:22 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
index 923620b068..534cf3b960 100644
--- a/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.core.filebuffers.tests;singleton:=true
-Bundle-Version: 3.13.600.qualifier
+Bundle-Version: 3.13.700.qualifier
 Bundle-Activator: org.eclipse.core.filebuffers.tests.FileBuffersTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 12m 48s ⏱️ - 5m 7s
 8 270 tests ±0   8 022 ✅ +1  248 💤 ±0  0 ❌  - 1 
23 634 runs  ±0  22 843 ✅ +1  791 💤 ±0  0 ❌  - 1 

Results for commit d5e2c06. ± Comparison against base commit 647256d.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the migrate-filebuffers-tests-junit5 branch 3 times, most recently from 0efa8e8 to a2e5927 Compare January 14, 2026 10:29
@vogella vogella force-pushed the migrate-filebuffers-tests-junit5 branch from a2e5927 to 4e1c321 Compare January 15, 2026 14:22
vogella and others added 3 commits January 15, 2026 15:23
Update test dependencies and convert test classes to use JUnit 5 imports, annotations, and assertions.
@vogella vogella force-pushed the migrate-filebuffers-tests-junit5 branch from 4e1c321 to d5e2c06 Compare January 15, 2026 14:24
@vogella
Copy link
Contributor Author

vogella commented Jan 15, 2026

Feedback applied

@vogella vogella merged commit 9f29191 into eclipse-platform:master Jan 16, 2026
18 checks passed
@vogella vogella deleted the migrate-filebuffers-tests-junit5 branch January 16, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants