Draft
Conversation
In order to try to make a more rationnal implementation of the support of keyed topics into visualizer code. Tryied to document the code so that it will be more clear to me what has to be done. Signed-off-by: Manuel Valch <manuelValch@proton.me>
Tried to describe series, and dds object creation so that I might have a better idea on how to implemented keyed topics and where to move object creation. Signed-off-by: Manuel Valch <manuelValch@proton.me>
If this commit si applied, then data reception sequence will be documented as it is much easier for me to plan necessary modifications for keyed topics handling. Signed-off-by: Manuel Valch <manuelValch@proton.me>
Updated dev documentation on how I plan to add key topics handling at startup so that It si more clear for everyone Signed-off-by: Manuel Valch <manuelValch@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add key annotation support for fastdds-visualizer-plugin.
To be done before draft status can be removed:
Please note that in order to use documentation, I have rebased this branch on documentation one referenced in this PR: #67
closes #56