[UI] Default fleet in project wizard #3464
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| onDiscard: () => onDiscard(uuid), | ||
| }), | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Confirmation dialog doesn't close after user confirms
High Severity
The useConfirmationDialog hook wraps onDiscard to close the dialog but doesn't wrap onConfirm. When the user clicks confirm, the original onConfirm callback runs but the dialog remains visible because close(uuid) is never dispatched. The dialog will stay open until the user clicks Cancel or dismisses it manually.
There was a problem hiding this comment.
onConfirm was implemented in ConfirmationDialof componentd
| } | ||
| }; | ||
|
|
||
| const getDefaultFleetSummary = () => { |
There was a problem hiding this comment.
Wizard submit triggered prematurely on Fleets step
Medium Severity
The onSubmit function checks activeStepIndex < 2 but the wizard now has 4 steps (indices 0-3). When on the Fleets step (index 2), pressing Enter triggers onSubmitWizard instead of navigating to Summary. The condition needs to be activeStepIndex < 3 to account for the new step.
| return value >= fleet_min_instances; | ||
| }), | ||
| }), | ||
| fleet_idle_duration: yup.string().matches(/^[1-9]\d*[smhdw]$/, 'Invalid duration'), |
There was a problem hiding this comment.
Idle duration validation rejects documented "0s" value
Medium Severity
The fleet_idle_duration validation regex /^[1-9]\d*[smhdw]$/ requires the first digit to be 1-9, but the description in en.json explicitly lists "0s" as a valid example. Users trying to enter "0s" (immediate termination) will get an "Invalid duration" error despite it being documented as valid.
There was a problem hiding this comment.
"0s" is invalid value, so we used this regular expression
| summaryFields.forEach((fieldName) => { | ||
| if (formValues[fieldName]) { | ||
| result.push(`${t(`projects.edit.${fieldName}`)}: ${formValues[fieldName]}`); | ||
| } |
There was a problem hiding this comment.
Summary excludes fleet min instances when zero
Low Severity
The getDefaultFleetSummary function uses if (formValues[fieldName]) which is a truthy check. Since fleet_min_instances defaults to 0 and 0 is falsy, the min instances field won't appear in the summary despite being a valid and common configuration value.
| return value >= fleet_min_instances; | ||
| }), | ||
| }), | ||
| fleet_idle_duration: yup.string().matches(/^[1-9]\d*[smhdw]$/, 'Invalid duration'), |
There was a problem hiding this comment.
Idle duration validation runs when fleet is disabled
Medium Severity
The fleet_idle_duration validation uses unconditional .matches() unlike fleet_min_instances and fleet_max_instances which wrap their validation in .when('enable_default_fleet', { is: true, then: ... }). If a user enters an invalid duration value, then disables the fleet toggle, validation still fails on the hidden field, blocking the wizard with no visible error message.
Close https://github.com/dstackai/dstack-cloud/issues/373
Note
Implements optional default fleet creation during project setup and introduces a reusable, global confirmation dialog mechanism.
Fleetsstep in the project wizard withFormToggle, fields forfleet_name,fleet_min_instances,fleet_max_instances, andfleet_idle_duration, Yup validation, help panel links, and a confirmation when min instances > 0; on submit, callsapplyFleetPOSTproject/{name}/fleets/apply(API.PROJECTS.FLEETS_APPLY),useApplyFleetMutation, and supportingfleettypescomponents/ConfirmationDialog/slice,useConfirmationDialoghook, and renders queued dialogs inAppLayout; updatesButtonWithConfirmationand user pages to use standardized dialog content/labelsFormTogglecomponent and exports; updates i18n strings for common and project wizard labels; minor UI label tweaks (e.g., "Create" button in projects list)Written by Cursor Bugbot for commit 3c3ae8c. This will update automatically on new commits. Configure here.