Mission download protocol implementation#1039
Open
eminakgun wants to merge 2 commits intodronekit:masterfrom
Open
Mission download protocol implementation#1039eminakgun wants to merge 2 commits intodronekit:masterfrom
eminakgun wants to merge 2 commits intodronekit:masterfrom
Conversation
This was referenced Jun 26, 2020
|
This PR did the trick for me -- no more timeouts after trying it out. Thanks for sharing and hope it gets merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements mission download properly by checking timeout of 500msecs in each request and re-requesting the whole mission or next item. Tested in SITL and real hardware running ArduPlane 3.9.11.