Skip to content

Add Windows-only support notes to ACL security types#12283

Merged
gewarren merged 2 commits intomainfrom
copilot/add-windows-support-remarks
Feb 6, 2026
Merged

Add Windows-only support notes to ACL security types#12283
gewarren merged 2 commits intomainfrom
copilot/add-windows-support-remarks

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Added platform support documentation to 16 types that provide Windows access control list (ACL) functionality for named synchronization objects (EventWaitHandle, Mutex, Semaphore).

Changes

Added a NOTE at the beginning of Remarks for:

System.Security.AccessControl namespace:

  • EventWaitHandleAccessRule, EventWaitHandleAuditRule, EventWaitHandleRights, EventWaitHandleSecurity
  • MutexAccessRule, MutexAuditRule, MutexRights, MutexSecurity
  • SemaphoreAccessRule, SemaphoreAuditRule, SemaphoreRights, SemaphoreSecurity

System.Threading namespace:

  • EventWaitHandleAcl, MutexAcl, SemaphoreAcl, ThreadingAclExtensions

Each type now includes:

> [!NOTE]
> This type is only supported on Windows.
Original prompt

Please add a note in the Remarks of the following types to indicate that they're only supported on Windows (unless such a remark already exists):

System.Security.AccessControl namespace:

  • EventWaitHandleAccessRule
  • EventWaitHandleAuditRule
  • EventWaitHandleRights (enum)
  • EventWaitHandleSecurity
  • MutexAccessRule
  • MutexAuditRule
  • MutexRights (enum)
  • MutexSecurity
  • SemaphoreAccessRule
  • SemaphoreAuditRule
  • SemaphoreRights (enum)
  • SemaphoreSecurity

System.Threading namespace:

  • EventWaitHandleAcl
  • MutexAcl
  • SemaphoreAcl
  • ThreadingAclExtensions

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Windows support notes to security and threading types Add Windows-only support notes to ACL security types Feb 6, 2026
Copilot AI requested a review from gewarren February 6, 2026 01:33
@gewarren gewarren marked this pull request as ready for review February 6, 2026 01:48
@gewarren gewarren requested a review from a team as a code owner February 6, 2026 01:48
Copilot AI review requested due to automatic review settings February 6, 2026 01:48
@gewarren gewarren enabled auto-merge (squash) February 6, 2026 01:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds platform support documentation to Windows-specific ACL (Access Control List) security types for named synchronization objects. The changes clarify that these types are only supported on Windows, improving developer understanding of platform limitations.

Changes:

  • Added Windows-only platform support notes to 12 ACL security types in System.Security.AccessControl namespace
  • Added Windows-only platform support notes to 4 ACL helper types in System.Threading namespace

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
xml/System.Threading/ThreadingAclExtensions.xml Added Windows support note to extension methods class for ACL management
xml/System.Threading/SemaphoreAcl.xml Added Windows support note to Semaphore ACL creation helper
xml/System.Threading/MutexAcl.xml Added Windows support note to Mutex ACL creation helper
xml/System.Threading/EventWaitHandleAcl.xml Added Windows support note to EventWaitHandle ACL creation helper
xml/System.Security.AccessControl/SemaphoreSecurity.xml Added Windows support note to Semaphore security descriptor type
xml/System.Security.AccessControl/SemaphoreRights.xml Added Windows support note to Semaphore access rights enumeration
xml/System.Security.AccessControl/SemaphoreAuditRule.xml Added Windows support note to Semaphore audit rule type
xml/System.Security.AccessControl/SemaphoreAccessRule.xml Added Windows support note to Semaphore access rule type
xml/System.Security.AccessControl/MutexSecurity.xml Added Windows support note to Mutex security descriptor type
xml/System.Security.AccessControl/MutexRights.xml Added Windows support note to Mutex access rights enumeration
xml/System.Security.AccessControl/MutexAuditRule.xml Added Windows support note to Mutex audit rule type
xml/System.Security.AccessControl/MutexAccessRule.xml Added Windows support note to Mutex access rule type
xml/System.Security.AccessControl/EventWaitHandleSecurity.xml Added Windows support note to EventWaitHandle security descriptor type
xml/System.Security.AccessControl/EventWaitHandleRights.xml Added Windows support note to EventWaitHandle access rights enumeration
xml/System.Security.AccessControl/EventWaitHandleAuditRule.xml Added Windows support note to EventWaitHandle audit rule type
xml/System.Security.AccessControl/EventWaitHandleAccessRule.xml Added Windows support note to EventWaitHandle access rule type

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 7409565 into main Feb 6, 2026
12 checks passed
@gewarren gewarren deleted the copilot/add-windows-support-remarks branch February 6, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants