Closed
Conversation
Key changes: - Add decrypt_data_blob_async() to prevent event loop blocking - Export Location, PhotoResult, RateLimitError from package root - Remove dead code (_parse_location_blob function) - Remove unused get_history start/end parameters - Fix lock message sanitization to re-collapse spaces after removing chars - Add docstrings to helper functions - Remove placeholder comment from helpers.py Test improvements: - Add test for async decryption method - Add test for empty sanitized lock message - Update test for removed _parse_location_blob - Achieve 100% branch coverage https://claude.ai/code/session_019KoQsx1g9tLyTsu2JakAnn
- Add CHANGELOG.md following Keep a Changelog format (v2.0.0 to current) - Document Raises sections for all public API methods in client.py - Update HOME_ASSISTANT_REVIEW.md to mark completed items https://claude.ai/code/session_019KoQsx1g9tLyTsu2JakAnn
Release includes: - decrypt_data_blob_async() for non-blocking decryption - Location, PhotoResult, RateLimitError exported from package root - CHANGELOG.md and comprehensive exception documentation - Lock message sanitization fix - Removed dead code and unused parameters No breaking changes for existing integrations. https://claude.ai/code/session_019KoQsx1g9tLyTsu2JakAnn
There was a problem hiding this comment.
Pull request overview
This pull request makes several bug fixes and test improvements to achieve 100% branch coverage, while also adding new async functionality and improving API exports for better discoverability.
Changes:
- Added
decrypt_data_blob_async()method to prevent event loop blocking in async contexts - Exported
Location,PhotoResult, andRateLimitErrorfrom package root for better API discoverability - Fixed lock message sanitization to properly handle messages containing only special characters
- Removed dead code (
_parse_location_blob()function) and unused parameters (start/endfromget_history()) - Added comprehensive docstrings with exception documentation to all public API methods
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fmd_api/client.py | Added decrypt_data_blob_async() method with executor-based async wrapper; added comprehensive docstrings with Raises sections for all public API methods |
| fmd_api/device.py | Removed unused _parse_location_blob() function; simplified get_history() by removing unused start/end parameters; fixed lock message sanitization to re-collapse whitespace after character removal |
| fmd_api/init.py | Added Location, PhotoResult, and RateLimitError to package exports |
| fmd_api/helpers.py | Added docstrings to helper functions; removed placeholder comment |
| fmd_api/_version.py | Updated version to 2.0.8 |
| pyproject.toml | Updated version to 2.0.8 |
| tests/unit/test_lock_message.py | Added test for lock messages containing only special characters |
| tests/unit/test_coverage_improvements.py | Added test for async decryption method; removed obsolete test for deleted _parse_location_blob function |
| CHANGELOG.md | Added new CHANGELOG following Keep a Changelog format with full release history |
| docs/HOME_ASSISTANT_REVIEW.md | Updated status for completed Home Assistant integration improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes:
Test improvements: