Fix iPhone Air camera specification to wide-only#477
Merged
Conversation
The iPhone Air only has a 48MP Fusion Main camera (wide), not an ultra-wide camera. Changed camera value from 13 (wide + ultraWide) to 1 (wide only) in Device.swift.gyb and regenerated Device.generated.swift. Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect camera designation for iPhone Air
Fix iPhone Air camera specification to wide-only
Dec 2, 2025
Zandor300
requested changes
Dec 2, 2025
Member
Zandor300
left a comment
There was a problem hiding this comment.
Please rebase on master and regenerate the swift file using new instructions.
Updated to use the new GYB command: ./Utils/gyb --line-directive '' -o ./Source/Device.generated.swift ./Source/Device.swift.gyb Fix remains: iPhone Air camera value changed from 13 to 1 (wide only). Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Contributor
Author
Rebased on master and regenerated the Swift file using the new GYB command ( |
Member
|
@copilot Please add a changelog entry. |
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Contributor
Author
Member
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Contributor
Author
Zandor300
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iPhone Air was incorrectly marked as having an ultra-wide camera. Per Apple specs, it only has a 48MP Fusion Main (wide) camera—no ultra-wide.
Changes Made
Device.swift.gybfrom13(wide + ultraWide) to1(wide only)Device.generated.swiftusing new GYB command__pycache__to.gitignoreResult
iPhone Air is also removed from
allDevicesWithUltraWideCamera.Fixes #463
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.