Apple Watch SE (3rd generation) support & Swift 5.3 -> 5.10#459
Closed
TopScrech wants to merge 3 commits intodevicekit:masterfrom
Closed
Apple Watch SE (3rd generation) support & Swift 5.3 -> 5.10#459TopScrech wants to merge 3 commits intodevicekit:masterfrom
TopScrech wants to merge 3 commits intodevicekit:masterfrom
Conversation
Author
Zandor300
requested changes
Oct 10, 2025
Member
Zandor300
left a comment
Zandor300
left a comment
There was a problem hiding this comment.
@TopScrech Thank you for your contribution! But you implemented inside the Swift file. That is not how our codebase works.
Changes have to be made inside the GYB file instead. Building the xcworkspace inside Xcode will trigger a generate of the Swift file.
Could you make the necessary changes?
|
Can someone please make this update the appropriate way and merge it into the main pod? |
Member
|
Closed in favour of #473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.