change windows behavior to not fire on handled exs#79
Open
davidgurnsey wants to merge 1 commit intoddopson:masterfrom
Open
change windows behavior to not fire on handled exs#79davidgurnsey wants to merge 1 commit intoddopson:masterfrom
davidgurnsey wants to merge 1 commit intoddopson:masterfrom
Conversation
Jesseyx
added a commit
to Jesseyx/node-segfault-handler
that referenced
this pull request
Dec 21, 2021
Jesseyx
added a commit
to Jesseyx/node-segfault-handler
that referenced
this pull request
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was pointed out here, handled exceptions are reported by
segfault-handlerbefore reaching their catch blocks. This change will make it so that handled exceptions pass silently.