Adding the ability to add a custom https agent.#163
Open
rashthedude wants to merge 1 commit intodanwrong:masterfrom
Open
Adding the ability to add a custom https agent.#163rashthedude wants to merge 1 commit intodanwrong:masterfrom
rashthedude wants to merge 1 commit intodanwrong:masterfrom
Conversation
|
+1 |
Collaborator
|
This would fix #81 |
Collaborator
|
Can you add a test? |
|
This would be great |
Author
|
I will add necessary tests. |
|
Any progress? |
Author
|
Sorry, but due to work commitments have I not been able to write the necessary tests. Should hopefully have them ready for the weekend. |
|
Maybe I can help you with the tests? I'd just need to have an example or something, because I've never done tests for node |
|
+1 |
Collaborator
|
@capablemonkey Happy to merge if you fancy adding some tests :) |
|
@easternbloc I've been struggling to figure out a way to test this change to be honest. Had a look through the current tests and I didn't see a way of testing an option. Testing setting an agent itself from the response also seems impossible. Any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a requirement such that we need to make non standard HTTPS calls. We need to alter the https agent and pass information on where to read the cert, ca and cert files are not provided by the connection.
An example use case is as follows
The pull request is super simple so would be excellent if you could merge it in.