Fix #14392 FN knownConditionTrueFalse (assigning function call result) #8118
Conversation
| ASSERT_EQUALS("", errout_str()); | ||
|
|
||
| check("struct S {\n" // #14392 | ||
| " bool g() const { return m; }\n" |
There was a problem hiding this comment.
We should make sure it doesnt warn when doing bool g() const { return true; }.
There was a problem hiding this comment.
Nevermind, this is a different warning.
|
|
This looks like a true positive: cppcheck/externals/tinyxml2/tinyxml2.cpp Line 1133 in bf76975 We don't catch this instance yet: Line 2927 in bf76975 |
| " }\n" | ||
| " return false;\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS("[test.cpp:6:12] -> [test.cpp:7:21]: (style) Condition 's.g()' is always true [knownConditionTrueFalse]\n", errout_str()); |
There was a problem hiding this comment.
It seems unfortunate to say that "Condition" is always true. The RHS in a assignment is not a "Condition".
There was a problem hiding this comment.
what happens if g() returns an int instead? That is not "true" or "false".
3 participants
No description provided.