Added bridging functionallity to PHP.#247
Open
kalaspuffar wants to merge 2 commits intodaisy:mainfrom
Open
Conversation
Collaborator
|
Apologies for not seeing this earlier. The way I have been dealing with language bindings is to have a separate repo (e.g, MathCATForC, MathCATForPython) that has wrappers for that language. The idea was not to "burden" the main library with these bindings. I don't think the current setup of using separate repos is a good idea and welcome suggestions for how to manage this better. Two ideas that have come up:
If you have any thoughts on either approach or another approach, I'd appreciate your feedback. I have heard from some people that I should avoid github submodules. Also see #193 for another approach to language bindings. |
5b62b71 to
43f1cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a couple of functions to the code so you can add this library as a PHP module and run it directly from the PHP code. I've seen that other glue codes have separate repositories, so this might not be how to implement this. I am still very early in my Rust journey, so I've not looked into multi-repository solutions.
I also did a small bug fix so the library doesn't have the name
liblibmathcat.soBest regards
Daniel