Open
Conversation
For details about the methods see: http://www.webdav.org/specs/rfc2518.html https://en.wikipedia.org/wiki/WebDAV
Contributor
Author
|
Just had a look at node's http-parser and they do support even more methods. What do you think about adding all of them? |
daedric
requested changes
Sep 9, 2017
| UNLOCK, | ||
| }; | ||
|
|
||
| std::string to_string(Method method); |
Owner
There was a problem hiding this comment.
You need to add those new methods to the to_string and method_from functions
| return true; | ||
| } | ||
| } | ||
| else if (*it == 'R') |
Owner
There was a problem hiding this comment.
since the stream based parser is deprecated and you'll add many more methods, maybe we can either delete it or simplify it ?
| case HTTPP::HTTP::Method::OPTIONS: | ||
| case HTTPP::HTTP::Method::TRACE: | ||
| case HTTPP::HTTP::Method::CONNECT: | ||
| case HTTPP::HTTP::Method::PROPFIND: |
|
|
||
| %%{ | ||
| method = ("GET" | "POST" | "HEAD" | "PUT" | "DELETE" | "OPTIONS" | "TRACE" | "CONNECT"); | ||
| method = ("GET" | "POST" | "HEAD" | "PUT" | "DELETE" | "OPTIONS" | "TRACE" | "CONNECT" | "PROPFIND" | "PROPPATCH" | "MKCOL" | "COPY" | "MOVE" | "LOCK" | "UNLOCK"); |
Owner
There was a problem hiding this comment.
if you don't add the methods in the method_from function, while parsed, you won't get the proper enum in the Request
Owner
|
I'm totally fine to have all those methods supported :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to do a small WebDAV test based on httpp. Found out that the methods defined in the WebDAV http extension are not supported by httpp atm, so I added them. Don't know whether you want them in the code base in the first place?
For details about the methods see:
http://www.webdav.org/specs/rfc2518.html
https://en.wikipedia.org/wiki/WebDAV