refactor: avoid json marshal protojson unmarshal roundtrip#89
Open
tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
refactor: avoid json marshal protojson unmarshal roundtrip#89tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Amund Tenstad <github@amund.io>
Signed-off-by: Amund Tenstad <github@amund.io>
tenstad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes the TODO in https://github.com/[crossplane-contrib/function-extra-resources](https://github.com/crossplane-contrib/function-extra-resources/blob/7eb0ff97188f79a44afd8506a9cfadf5d60a75b0/fn.go#L91-L93)/blob/7eb0ff97188f79a44afd8506a9cfadf5d60a75b0/fn.go#L91-L93
by returning
map[string]anyfromverifyAndSortExtrasand usingstructpb.NewStruct.Note: if it's desired to keep the
map[string][]unstructured.Unstructuredoutput type ofverifyAndSortExtras, I'm happy to revert the 2nd commit.I have:
Added or updated unit tests for my change.