Skip to content

Remove -fcoroutines and -fexperimental-library flags#181

Merged
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/flags
Feb 27, 2026
Merged

Remove -fcoroutines and -fexperimental-library flags#181
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/flags

Conversation

@sgerbino
Copy link
Collaborator

@sgerbino sgerbino commented Feb 27, 2026

Capy now propagates these as PUBLIC compile options, making local flag-setting redundant for downstream consumers.

Summary by CodeRabbit

  • Chores
    • Simplified build configurations by removing unnecessary compiler flags from continuous integration workflows and CMake build scripts across macOS, Linux, and FreeBSD platforms.

Capy now propagates these as PUBLIC compile options, making
local flag-setting redundant for downstream consumers.
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21875c3 and 7da26fb.

⛔ Files ignored due to path filters (3)
  • build/Jamfile is excluded by !**/build/**
  • perf/bench/CMakeLists.txt is excluded by !**/bench/**
  • test/unit/Jamfile is excluded by !**/test/**
📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • .github/workflows/code-coverage.yml
  • CMakeLists.txt
  • cmake/CorosioBuild.cmake
💤 Files with no reviewable changes (2)
  • cmake/CorosioBuild.cmake
  • CMakeLists.txt

📝 Walkthrough

Walkthrough

The pull request removes experimental and unsupported compiler flags from build configurations across CI/CD workflows and CMake files. Specifically, -fexperimental-library is eliminated from macOS and Linux build configurations in GitHub Actions workflows, while -fcoroutines GNU-specific flags are removed from CMake build system definitions.

Changes

Cohort / File(s) Summary
CI Workflows
.github/workflows/ci.yml, .github/workflows/code-coverage.yml
Removed -fexperimental-library flag from macOS Apple-Clang compiler configurations and coverage-related build steps across multiple configurations, simplifying cxxflags to use --coverage alone where applicable.
CMake Build System
CMakeLists.txt, cmake/CorosioBuild.cmake
Removed GNU-specific -fcoroutines compile option from boost_corosio target and corosio_add_tls_library function, eliminating compiler-specific coroutine handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Possibly related PRs

Poem

🐰 Experimental flags, we bid thee farewell,
No coroutines forced, our builds run so well!
Simplified configurations, clean and serene,
The cleanest CI workflows we've ever seen! ✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing two specific compiler flags (-fcoroutines and -fexperimental-library) from the configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.22%. Comparing base (21875c3) to head (7da26fb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #181   +/-   ##
========================================
  Coverage    76.22%   76.22%           
========================================
  Files           98       98           
  Lines        10467    10467           
  Branches      2383     2383           
========================================
  Hits          7978     7978           
  Misses        1762     1762           
  Partials       727      727           
Flag Coverage Δ
windows 69.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21875c3...7da26fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://181.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-02-27 14:56:12 UTC

@cppalliance-bot
Copy link

GCOVR code coverage report https://181.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://181.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://181.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-02-27 15:03:12 UTC

@sgerbino sgerbino merged commit e5a1b2a into cppalliance:develop Feb 27, 2026
22 checks passed
@sgerbino sgerbino deleted the pr/flags branch February 27, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants