refactor: update the sidebar and remove the topbar#107
Merged
tudoramariei merged 11 commits intomainfrom Sep 1, 2025
Merged
Conversation
5f36219 to
205d59c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the frontend navigation system by removing the old topbar component and updating the sidebar implementation. The changes involve restructuring user types, moving navigation components to a new directory structure, and updating translation keys to support the new navigation layout.
- Refactored user type definitions to use more consistent naming conventions
- Moved navigation components from
paul/topaul/navigation/directory - Replaced topbar functionality with an updated sidebar that includes user menu and mobile support
Reviewed Changes
Copilot reviewed 35 out of 38 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/types/user.ts | Updated user type definitions with new field names and structure |
| frontend/src/types/team-*.ts | Updated imports to use new UserProps type |
| frontend/src/types/common-props.ts | Split CommonProps into blank and authenticated variants |
| frontend/src/pages/users/team/ | Updated type imports and field name references |
| frontend/src/locales/ | Moved topbar translation keys to navigation section |
| frontend/src/layouts/ | Updated layout components to use new navigation structure |
| frontend/src/components/paul/navigation/ | New navigation components including sidebar, topbar, and user menu |
| frontend/src/components/ui/sidebar.tsx | Updated sidebar implementation with extracted context |
| backend/users/ | Added to_json method and updated serialization logic |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.