instance: Fix uninitialized memory#15
Merged
kkoreilly merged 1 commit intocogentcore:mainfrom Jan 6, 2026
Merged
Conversation
obiwac
added a commit
to inobulles/aqua
that referenced
this pull request
Dec 29, 2025
obiwac
added a commit
to inobulles/aqua
that referenced
this pull request
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion from the Go type to the C type assumes this memory is zeroed. But it might not be zeroed, in which case conversion back from C to Rust will fail in
webgpu-native(specifically inmap_instance_descriptor).There might be other places where memory is meant to be zeroed but isn't - I'll go through all
malloccalls when I have time :)