Open
Conversation
neSpecc
requested changes
Aug 26, 2021
workers/release/README.md
Outdated
| **Current implementation supports only single Rabbit prefetch count (SIMULTANEOUS_TASKS=1)** | ||
|
|
||
| ## Source maps delivery scheme | ||
| ## Delivery scheme |
Member
There was a problem hiding this comment.
Suggested change
| ## Delivery scheme | |
| ## Release delivery scheme |
| 1. User wants to deploy project | ||
| 2. He runs deploy script on the server and it runs static builder, for example Webpack. | ||
| 3. After Webpack finished his job, our [Webpack Plugin](https://github.com/codex-team/hawk.webpack.plugin) gets a source maps for new bundles and sends them to us. | ||
|
|
workers/release/README.md
Outdated
|
|
||
| 4. Collector accepts file and give a task for ReleaseWorker for saving it to DB | ||
| 5. ReleaseWorker saves it to DB. | ||
| 4. Collector accepts files and give a task for ReleaseWorker for saving it to the database. |
Member
There was a problem hiding this comment.
Suggested change
| 4. Collector accepts files and give a task for ReleaseWorker for saving it to the database. | |
| 4. Collector accepts commits and source map files and give a task for ReleaseWorker for saving it to the database. |
workers/release/README.md
Outdated
| 5. ReleaseWorker saves commits and source maps to the database. | ||
|
|
||
| ## Script for sending comments | ||
| To make it easier to send commits, you can use a [shell script](./scripts/commits.sh) that will take the last few commits and send them to the collector |
Member
There was a problem hiding this comment.
Suggested change
| To make it easier to send commits, you can use a [shell script](./scripts/commits.sh) that will take the last few commits and send them to the collector | |
| To make it easier to send commits, you can use a [shell script](./scripts/commits.sh) that will take the last few commits and send them to the collector |
workers/release/scripts/commits.sh
Outdated
| @@ -0,0 +1,92 @@ | |||
| #!/bin/sh | |||
Member
There was a problem hiding this comment.
move it to the separate repository (hawk-release for example), because it is not related to workers.
neSpecc
approved these changes
Aug 26, 2021
Member
Author
|
Closed in codex-team/hawk.releases#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a script to make it a little easier to send comments to the collector. The first step towards cli