Skip to content

Comments

Issue 132 don't render game embed if game embed field is null#134

Open
KushPatel-18 wants to merge 2 commits intomainfrom
issue-132-Don_t_render_game_embed_if_game_embed_field_is_null
Open

Issue 132 don't render game embed if game embed field is null#134
KushPatel-18 wants to merge 2 commits intomainfrom
issue-132-Don_t_render_game_embed_if_game_embed_field_is_null

Conversation

@KushPatel-18
Copy link
Collaborator

@KushPatel-18 KushPatel-18 commented Feb 21, 2026

Change Summary

Swaps condition from game embed is not "0", to if game embed is not null on individual game pages. This is meant to allow for the front end to not render an embed if an embed id is not given

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

Both this issue and issue 112 make the same change for allowing hostURL be null in game model as both require that for the change. They're both the same however.

Related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't render game embed if game embed field is null

1 participant