Issue 124 add event link to individual game page#130
Open
bilibilistack wants to merge 3 commits intomainfrom
Open
Issue 124 add event link to individual game page#130bilibilistack wants to merge 3 commits intomainfrom
bilibilistack wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
#124


This pull request introduces improvements to how game events are displayed and fetched on the individual game page. The main changes include dynamically fetching event data for each game, updating the event display logic, and enhancing the backend to restrict access to unpublished events.
In case no events or unpublished:
Frontend: Event integration and display
useEventhook to fetch event data based on the game's associated event, replacing the previous hardcoded event placeholder. (client/src/pages/games/[id].tsxR8, client/src/pages/games/[id].tsxR21-R23)Backend: Event access control
EventDetailAPIViewto only allow access to events that have been published (i.e., theirpublicationDateis not in the future), and to return a clear error message if the event is unpublished or does not exist.Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Related issue