Issue 69 add landing sparkles and explosions#125
Open
phillipnguyenn wants to merge 24 commits intomainfrom
Open
Issue 69 add landing sparkles and explosions#125phillipnguyenn wants to merge 24 commits intomainfrom
phillipnguyenn wants to merge 24 commits intomainfrom
Conversation
…d land corner of image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Completed:
Created 3 images for Pixel Art Sparkles, 2 of which will be randomly selected to be displayed in the event highlight section upon a load. Pixel Art Images are created by Yours Truly ™ (Me).
Added an Explosion react component that can display an explosion of pixels. Parameters can be passed to the component to display different amount of colours and particles. To account for the bomb, the component can take an X and Y offset to center the explosion effect behind the image art.
In Progress:
Changing the sparkles to reuse the Explosion component for a sparkle/explosion effect.
Fix the Sparkle re-render bug (on click of the explosion of the bomb, see attached below).
Change Form
Other Information
The sparkles re-render upon clicking the bomb for an explosion although cool is not intended.
The possible fix is to localise the logic in the component for setting an explosion and unsetting.
The logic for the explosion setting is currently on the landing page (index) which may be the reason why it is causing a re-render of the sparkles.