Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
There is some errors with the static files as i havent decided on the actual path for serving on the hosting vm. |
dct0
requested changes
Nov 23, 2024
Contributor
dct0
left a comment
dct0
left a comment
There was a problem hiding this comment.
Nice work! Few comments relating from the dev perspective
Contributor
There was a problem hiding this comment.
Don't remove these, you can just open the repo without the dev container
| RUN chmod +x /entrypoint.sh | ||
| CMD ["/entrypoint.sh"] | ||
|
|
||
| # TODO: Production No newline at end of file |
Contributor
There was a problem hiding this comment.
Typically a prod build would have nextjs build as "standalone" and that would be then copied inside the container, but this should be fine for most purposes
harryrigg
reviewed
Nov 25, 2024
- Added env variable from project root in django settings.py - Brought .env.examples back to life
Updated from django files as per Yunho's recs to fix some of the issues occuring while building
Frontend deploys successfully! Backend in progress: Trying to get it to createsuperuser. command doesnt work manually in the container on vps atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Modified codebase for production.
Main changes:
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
NO