Fix handling of .. in jepath() (requires <filesystem> header)#170
Fix handling of .. in jepath() (requires <filesystem> header)#170juntuu wants to merge 2 commits intocodereport:mainfrom
.. in jepath() (requires <filesystem> header)#170Conversation
|
The Ci uses G++ 7.5, which is kind of ancient. From the top of my head, you need version 8 to get full support for C++-17, which introduced the We could work around this problem with a bunch of regexes and dealing with a lot of corner cases, but I'm pretty sure we're going to run into similar problems again when we try to convert code to C++-20. So I guess we're up for another 5 hour episode of getting a CI to run ;) |
I think in this case it's better to just wait, as c++20 will anyways be the eventual target. Also the issue is not too bad to work with. |
.. in jepath().. in jepath() (requires <filesystem> header)
Resolves #169
Oh,
<filesystem>header is not available...I'll leave this here for now, until the future of possibly supporting compiler is cleared
After this fix
../path components are correctly backed off.The backing off is done lexically, as was before in the C version, so traversing through symlink and then back (to the parent of the symlinked directory) with ".." still fails.