Fix resolving devices by defining the correct search key#136
Merged
cmeissner merged 3 commits intocodeaffen:developfrom Jul 12, 2025
Merged
Fix resolving devices by defining the correct search key#136cmeissner merged 3 commits intocodeaffen:developfrom
cmeissner merged 3 commits intocodeaffen:developfrom
Conversation
To guarantee that the introduced change work as expected, a test case `address_device_mapping` was added too. Second a short fragment for the changelog was added.
Member
|
@Talkabout, thank you for filing this pull request. I updated the description a bit for others to better follow what it will achieve. I also added a test case for that special combination of address and device to be sure the code is working. Also, a short changelog fragment was added to have a corresponding entry in the changelog of the upcoming version. After granting you the permissions to trigger actions to run on push, I also realized that something seems to be broken. I will try to investigate on this issue, if I found time. You are also invited to invest some time to get to the root cause of that failure in CI. |
Due to timing problems with running tests in parallel with only 4 runners we increases the amount of runners to 8 to mitigate conflicting actions. This is only a workaround and the tests need to be refactored to prevent conflicting actions by using random data.
Contributor
Author
|
@cmeissner Thanks for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining a device, for example, in the address module, it fails due to the wrong search key when calling
find_by_keyin_resolve_entity.Due to the fields needed for a device entity in phpIPAM API:
By introducing an extra case for controller
tools/deviceswe can override the default search key withhostname.