Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds exact-match NGO search support: a helper to detect registration numbers, a new Changes
Sequence DiagramsequenceDiagram
participant Client as Client
participant Mixin as NgoCauseMixedSearchMixin
participant Flags as FeatureFlag
participant Exact as NgoExactSearchMixin
participant Fuzzy as NgoSearchMixin
participant DB as Database
Client->>Mixin: get_search_results(query)
Mixin->>Flags: check ENABLE_NGO_SEARCH_EXACT_MATCH
alt Exact match enabled & query qualifies
Flags-->>Mixin: True
Mixin->>Exact: get_search_results(query)
Exact->>DB: filter NGOs by name__icontains OR registration_number
DB-->>Exact: exact_ngos
Exact->>DB: filter causes by exact_ngos
DB-->>Exact: exact_causes
Exact-->>Mixin: exact_causes
Mixin-->>Client: return exact_causes (if any)
else Fallback to fuzzy flow
Flags-->>Mixin: False or query not qualifying
Mixin->>Fuzzy: get_search_results(query)
Fuzzy->>DB: fuzzy match NGOs and causes
DB-->>Fuzzy: fuzzy_ngos, fuzzy_causes
Fuzzy-->>Mixin: fuzzy results
Mixin->>DB: direct cause search (searched_causes)
DB-->>Mixin: searched_causes
Mixin-->>Client: return searched_causes + fuzzy_causes
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Greptile SummaryAdds exact match search capability for NGOs, prioritizing exact name matches and registration number lookups over fuzzy search. Introduces Key changes:
Issues found:
Confidence Score: 2/5
|
| Filename | Overview |
|---|---|
| backend/donations/views/common/search.py | Added NgoExactSearchMixin for exact matching and integrated it into mixed search with feature flag; logic mismatch between trigger condition and actual search behavior found |
| backend/redirectioneaza/settings/feature_flags.py | Added ENABLE_NGO_SEARCH_EXACT_MATCH feature flag with default value True |
Flowchart
flowchart TD
A[Search Query] --> B{Feature Flag Enabled?}
B -->|No| G[Fuzzy Search Only]
B -->|Yes| C{Trigger Exact Match?}
C -->|No| G
C -->|Yes| D[NgoExactSearchMixin]
D --> E{Results Found?}
E -->|Yes| F[Return Exact Results]
E -->|No| G
G --> H[NgoSearchMixin Fuzzy]
G --> I[CauseSearchMixin]
H --> J[Union Results]
I --> J
J --> K[Return Combined Results]
Last reviewed commit: 5740c94
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
Before applying any fix, first verify the finding against the current code and
decide whether a code change is actually needed. If the finding is not valid or
no change is required, do not modify code for that item and briefly explain why
it was skipped.
In `@backend/donations/views/common/search.py`:
- Line 80: Fix the typo in the inline comment in search.py (the comment that
reads "Try to guess is the user is looking for a registration number") by
changing "is" to "if" so it reads "Try to guess if the user is looking for a
registration number"; update the comment in the same location within the
relevant function or block where that line appears.
- Around line 155-156: The truthiness check "if exact_causes:" forces evaluation
of the entire queryset; change it to use the lightweight EXISTS check by
replacing that condition with "if exact_causes.exists():" so the code performs
an efficient EXISTS query and still returns the queryset (exact_causes) for the
paginated NgoListHandler (paginate_by = 8).
🧹 Nitpick comments (1)
🤖 Fix all nitpicks with AI agents
Before applying any fix, first verify the finding against the current code and decide whether a code change is actually needed. If the finding is not valid or no change is required, do not modify code for that item and briefly explain why it was skipped. In `@backend/donations/views/common/search.py`: - Around line 155-156: The truthiness check "if exact_causes:" forces evaluation of the entire queryset; change it to use the lightweight EXISTS check by replacing that condition with "if exact_causes.exists():" so the code performs an efficient EXISTS query and still returns the queryset (exact_causes) for the paginated NgoListHandler (paginate_by = 8).backend/donations/views/common/search.py (1)
155-156: Consider using.exists()for more efficient queryset check with pagination.Using
if exact_causes:evaluates the entire queryset and caches all results. SinceNgoListHandleruses pagination (paginate_by = 8), using.exists()would be more efficient—it runs a lightweightEXISTSquery, and only the paginated subset is fetched later.Proposed fix
- if exact_causes: + if exact_causes.exists(): return exact_causes🤖 Prompt for AI Agents
Before applying any fix, first verify the finding against the current code and decide whether a code change is actually needed. If the finding is not valid or no change is required, do not modify code for that item and briefly explain why it was skipped. In `@backend/donations/views/common/search.py` around lines 155 - 156, The truthiness check "if exact_causes:" forces evaluation of the entire queryset; change it to use the lightweight EXISTS check by replacing that condition with "if exact_causes.exists():" so the code performs an efficient EXISTS query and still returns the queryset (exact_causes) for the paginated NgoListHandler (paginate_by = 8).
Collaborator
Author
|
Attempt to fix #622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit