This repository was archived by the owner on Nov 29, 2020. It is now read-only.
Fix #79 and #82 Add phone number prefix#124
Open
khyper wants to merge 3 commits intocode4romania:developfrom
Open
Fix #79 and #82 Add phone number prefix#124khyper wants to merge 3 commits intocode4romania:developfrom
khyper wants to merge 3 commits intocode4romania:developfrom
Conversation
khyper
changed the title
aniri
suggested changes
Apr 1, 2019
Member
aniri
left a comment
aniri
left a comment
There was a problem hiding this comment.
the country code picker is not vertically aligned the same as the phone number. could you try to align them?
aniri
reviewed
Apr 1, 2019
| <string name="hint_time">hh:mm</string> | ||
| <string name="empty" /> | ||
| <string name="error_empty_credentials">Introduceți numărul de telefon şi codul primit.</string> | ||
| <string name="error_invalid_phone_number">Numarul de telefon nu este valid.</string> |
Member
|
@RaduCStefanescu @bvizureanu we will have to check with the back-end to see if we can support also country code for phone numbers. also we have to agree on the accepted phone number format 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.