Skip to content

Change flow setting object conversion to use Value.from_ruby#840

Closed
Knerio wants to merge 2 commits intomainfrom
change-object-to-value
Closed

Change flow setting object conversion to use Value.from_ruby#840
Knerio wants to merge 2 commits intomainfrom
change-object-to-value

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Jan 28, 2026

No description provided.

@Knerio
Change object conversion to use Value.from_ruby
d78a065 
Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
@Knerio Knerio requested a review from Taucher2003 January 28, 2026 14:16
@Knerio Knerio self-assigned this Jan 28, 2026
@Knerio Knerio changed the title Change object conversion to use Value.from_ruby Change flow setting object conversion to use Value.from_ruby Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245

Status: Failed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12898848465/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245/test_report
Finished in 23.87 seconds (files took 11.05 seconds to load)
1322 examples, 1 failure
Line Coverage: 91.63% (4597 / 5017)
[TEST PROF INFO] Time spent in factories: 00:13.158 (42.98% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12898848463/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245/test_report
Finished in 23.84 seconds (files took 10.48 seconds to load)
1275 examples, 1 failure
Line Coverage: 91.09% (4429 / 4862)
[TEST PROF INFO] Time spent in factories: 00:12.780 (42.16% of total time)

rubocop

736 files inspected, no offenses detected

@Knerio
Rename 'object' to 'value' in to_grpc method
ecc910e 
Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
@Knerio Knerio closed this Jan 28, 2026
@Knerio Knerio deleted the change-object-to-value branch January 28, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Awaiting requested review from Taucher2003

Assignees

@Knerio Knerio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Knerio