Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new runtime definition for a "value" function in the control namespace (std::control::value), which appears to be a pass-through function that accepts a value of generic type R and returns it. The change resolves issue #232 and includes both the function definition and an audit log entry.
Changes:
- Added new runtime definition file for
std::control::valuefunction with generic type support - Updated control-audit.md to document the addition on 06.02.2026
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| definitions/standard/runtime_definition/control/std_control_value.proto.json | New runtime definition for the value function with generic type R, following the standard JSON schema structure |
| definitions/standard/runtime_definition/control/control-audit.md | Added audit log entry documenting the addition of the value function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/control/std_control_value.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/control/std_control_value.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/control/std_control_value.proto.json
Show resolved
Hide resolved
…lue.proto.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #232