Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new std::object::get function to retrieve values from objects by key. The implementation follows the pattern established by other object manipulation functions in the standard library, providing generic type support for flexible value retrieval.
Changes:
- Added
std_object_get.proto.jsonwith runtime definition for the get function - Updated
object-audit.mdto document the addition and note future type system improvements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| definitions/standard/runtime_definition/object/std_object_get.proto.json | Defines the runtime signature, parameters, return type, and metadata for the object get function |
| definitions/standard/runtime_definition/object/object-audit.md | Documents the addition of the get function and includes a TODO note about future type signature improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/object/std_object_get.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_get.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_get.proto.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
…proto.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.