-
Notifications
You must be signed in to change notification settings - Fork 46
Optimise download many #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ObadaS
wants to merge
26
commits into
develop
Choose a base branch
from
optimise_download_many
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Optimise download many #2001
+327
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimise download many
Optimise download many
48a7f28 to
53a0f73
Compare
Add download many results and predictions
Member
|
Flake8 issues to be fixed: ^@^@src/apps/api/views/submissions.py:221:1: W293 blank line contains whitespace
src/apps/api/views/submissions.py:223:5: E303 too many blank lines (2)
src/apps/api/views/submissions.py:223:42: E231 missing whitespace after ','
src/apps/api/views/submissions.py:223:50: E231 missing whitespace after ','
src/apps/api/views/submissions.py:416:5: E265 block comment should start with '# '
src/apps/api/views/submissions.py:416:174: W291 trailing whitespace
src/apps/api/views/submissions.py:418:5: F811 redefinition of unused 'download_many' from line 407
src/apps/api/views/submissions.py:426:1: W293 blank line contains whitespace
src/apps/api/views/submissions.py:471:35: E201 whitespace after '['
src/apps/api/views/submissions.py:471:57: E261 at least two spaces before inline comment
src/apps/api/views/submissions.py:471:58: E262 inline comment should start with '# '
src/apps/api/views/submissions.py:475:26: F821 undefined name 'serializer'
src/apps/api/views/submissions.py:476:13: E265 block comment should start with '# '
src/apps/api/views/submissions.py:476:136: W291 trailing whitespace
src/apps/api/views/submissions.py:479:1: W293 blank line contains whitespace
src/apps/api/views/submissions.py:481:1: W293 blank line contains whitespace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #1999 from @nicomy
@ mention of reviewers
@Didayolo @ObadaS @ihsaan-ullah
A brief description of the purpose of the changes contained in this PR.
This PR improves the Bulk Download functionality.
The preivous bulk download triggered multiple database queries, which was inefficient and error-prone. This PR refactors the process so that:
A progress bar UI try to give users feedback on the download progress.
Issues this PR resolves
Related:
A checklist for hand testing
Any relevant files for testing
Previous Issue
Checklist