refactor: rename dropdownContentRole to ariaRole #4248
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4248 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 888 889 +1
Lines 26031 26040 +9
Branches 9411 9417 +6
=======================================
+ Hits 25343 25352 +9
Misses 641 641
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mxschll
force-pushed
the
dev-v3-schomax-dropdown-aria
branch
from
4d77dbc to
6630f2d
Compare
mxschll
commented
Feb 17, 2026
| ref={contentRef} | ||
| id={id} | ||
| role={role} | ||
| role={ariaRole} |
Member
Author
There was a problem hiding this comment.
That's on the div, so it stays role :)
YueyingLu
reviewed
Feb 18, 2026
| <Dropdown trigger={<button />} open={false} ariaRole="dialog" content={<div>Content</div>} /> | ||
| ); | ||
| // Dropdown content exists in DOM even when closed (for transitions) | ||
| const dropdownContainer = wrapper.getElement().querySelector('[aria-hidden]'); |
Member
There was a problem hiding this comment.
I do not recommend to query aria-hidden and check for the same attribute. Can you query data-tesetid instead?
Member
Author
There was a problem hiding this comment.
Good catch, thanks. We don't have a data-testid on the dropdown content wrapper. I'll query for data-open so we don't have the same attribute.
YueyingLu
requested changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dropdownContentRoleprop of the Dropdown component to be namedariaRolealigning its API with FlashbarariaLabelpropRelated
[Quip proposal:
RGJgABPXohP8]How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.