fix: Deduplicate CSS by hoisting shared styles to base selectors#4152
Open
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Open
fix: Deduplicate CSS by hoisting shared styles to base selectors#4152TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
Move repeated declarations from size/variant-specific selectors to base classes, reducing compiled CSS output: - icon: box-sizing and vertical-align to .icon base class - spinner: remove redundant box-sizing from size loop (already on .root) - tiles: remove redundant box-sizing from column loop (already on .tile-container) - button: hoist text-decoration and position to .button base class Total savings: ~1.3KB across affected components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that some CSS declarations were being repeated in loops. For example, the class for each icon size has the same
box-sizingandvertical-aligndeclarations.This PR moves those declarations to avoid repetition, reducing the amount of generated CSS by ~1.3KB (total) across the icon, spinner, tiles, and button components.
How has this been tested?
Since this is purely a CSS change, the screenshot tests (which I don't have the ability to run) should be definitive.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.