Skip to content

fix: Dismiss tooltip on Escape key at all keyboard navigation levels#169

Open
Who-is-PS wants to merge 3 commits intomainfrom
dev-v3-philosr-esc-fix
Open

fix: Dismiss tooltip on Escape key at all keyboard navigation levels#169
Who-is-PS wants to merge 3 commits intomainfrom
dev-v3-philosr-esc-fix

Conversation

@Who-is-PS
Copy link
Member

@Who-is-PS Who-is-PS commented Feb 16, 2026

Description

Previously, pressing Escape while keyboard-navigating a chart would only navigate up the focus hierarchy (point → group → chart) without dismissing the visible tooltip first. This was inconsistent with the expected behavior where Escape should dismiss any open tooltip before navigating.

Changes

  • Added onDismissHoverTooltip handler that dismisses visible non-pinned tooltips and returns whether a tooltip was dismissed
  • Updated Escape key handling at all three navigation levels (chart, group, point) to dismiss the tooltip first, and only navigate up if no tooltip was dismissed
  • Updated navigation tests to reflect the new two-step Escape behavior

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to handle the case here as well? If the tooltip is open, dismiss it; if not, do the default logic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Updated to dismiss tooltip first if visible, then navigate if not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Updated to dismiss tooltip first if visible, then navigate if not

@Who-is-PS Who-is-PS changed the title fix: Tooltip ecs fix: Dismiss tooltip on Escape key at all keyboard navigation levels Feb 18, 2026
@Who-is-PS Who-is-PS marked this pull request as ready for review February 18, 2026 15:30
@Who-is-PS Who-is-PS requested a review from a team as a code owner February 18, 2026 15:30
@Who-is-PS Who-is-PS requested review from avinashbot and georgylobko and removed request for a team and georgylobko February 18, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments