Add TimescaleDB extension support#73
Conversation
|
Hi @shusaan, can you please resubmit the PR by following the scaffolding instructions and then the local testing part in the BUILD.md file? Thanks. |
|
Hi @shusaan, can you please update your PR using the new scaffolding procedure and making sure you test it? Also, please use the official PGDG packages, as they are available there (we prefer the Postgres official source). Finally, can you please write some smoke tests that verify that Timescale is installed? (look at the PostGIS extension for examples). |
|
Hi @gbartolini, I've investigated using PGDG packages for TimescaleDB as requested. The issue: The PGDG package postgresql-18-timescaledb contains both Apache 2.0 and TSL (Timescale License) code. There is no Apache 2.0-only package available in the official PGDG repository. I verified this by running: The Apache 2.0-only packages (timescaledb-2-oss-postgresql-*) are only available from TimescaleDB's own repository (packagecloud.io), not from PGDG. Options: Keep using TimescaleDB's repository with the OSS package (current approach). Here is discussion about TimescaleDB License. What do you suggest? |
|
postgresql-18-timescaledb is OSS version. I haven't found TSL version in PGDG APT, but found it in a separate repo for redhat-based distros: https://download.postgresql.org/pub/repos/yum/non-free/18/redhat/rhel-10-x86_64/ Also, I am not sure TSL license allows such manipulations, so it should be a political decision about inclusion of TSL version. |
|
Hi @gbartolini I've updated the PR as per the requirements. Please let me know if any further changes are needed. |
|
Hi @shusaan I will, thanks for the contribution. |
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Includes smoke tests for hypertable functionality and uses Apache 2.0-only packages from TimescaleDB repository Signed-off-by: Husn E Rabbi <shussan@gmail.com>
2fbe9a8 to
7613a4f
Compare
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
|
I have opened a support ticket within the CNCF to get legal advice before merging. Thanks for your patience. |
|
@shusaan, regarding your PR, I have made some minor changes, primarily formatting but also renaming the extension (not on the SQL level though). I have renamed it |
|
In the meantime, I confirm what @gugu was saying. Start a container: Then: I get this: The last line says: This package contains the Apache-licensed version of timescaledb. I proceeded installing the package and checked the As a result, I would prefer to stick with the PGDG package @shusaan. Do you think you can do that? (please pull my changes first, thanks). |
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
@gbartolini I have updated, please check |
This PR adds support for the timescaledb extension to the postgres-extensions-containers project.
This PR supersedes #30 and incorporates the same changes, addressing the feedback and discussion from that PR.
Closes #58
Changes