Skip to content

feat: support private registries for e2e#112

Open
GabriFedi97 wants to merge 7 commits intocloudnative-pg:mainfrom
GabriFedi97:dev/105
Open

feat: support private registries for e2e#112
GabriFedi97 wants to merge 7 commits intocloudnative-pg:mainfrom
GabriFedi97:dev/105

Conversation

@GabriFedi97
Copy link
Contributor

@GabriFedi97 GabriFedi97 commented Feb 16, 2026

Add support for passing extra arguments to the Chainsaw test command exposed by the dagger module. This way, a docker-credentials secret can be created beforehand in a dedicated namespace and the same namespace can be used by Chainsaw by passing the extra args "--namespace,<namespace>".

Add also the options to pass credentials for generating Chainsaw testing values for container images hosted in private registries.

closes: #105

@GabriFedi97 GabriFedi97 force-pushed the dev/105 branch 2 times, most recently from f08538e to 2e3a98b Compare February 16, 2026 14:00
@GabriFedi97 GabriFedi97 changed the title Support private registries for e2e feat: support private registries for e2e Feb 17, 2026
@GabriFedi97 GabriFedi97 marked this pull request as ready for review February 17, 2026 09:14
@GabriFedi97 GabriFedi97 requested review from a team and NiccoloFei as code owners February 17, 2026 09:14
@GabriFedi97
Copy link
Contributor Author

I realized there might be more convenient way to set up private credentials for e2e, which is configuring them directly in the kind nodes as docker config at path /var/lib/kubelet/config.json. This way no extra steps and no pull-secrets handling would be required.
Putting the PR back to draft to test this approach.

@GabriFedi97 GabriFedi97 marked this pull request as draft February 18, 2026 10:01
@GabriFedi97 GabriFedi97 force-pushed the dev/105 branch 2 times, most recently from 6505091 to f2b151a Compare February 18, 2026 12:33
@GabriFedi97 GabriFedi97 marked this pull request as ready for review February 18, 2026 12:34
@GabriFedi97
Copy link
Contributor Author

I confirm the new approach works fine and looks cleaner.

Although the extraArgs parameter for the Dagger test function is not theoretically required anymore for enabling e2e for private registries, I think it's worth keeping it for more complex use-cases. Same thing for the option of configuring an imagePullSecret for Clusters through Chainsaw values.

Support passing credentials for testing values generation
in the dagger module.

Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Support passing extra arguments to Chainsaw test
execution. This way the test cmd can be customised
by external callers and it can support more complex use-cases

Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support running e2e with private registries

2 participants

Comments