Skip to content

Conversation

@rashedkvm
Copy link
Contributor

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Add state_reason in Stack object

  • An explanation of the use cases your change solves
    See RFC#0045 (Stack Management)
    Includes state_reason in Stack Validation Error and Warning. See RFC#0045 (Stack Management). Includes state_reason in Stack Validation Error and Warning

  • Links to any other associated PRs
    Enhance stack handling with state_reason field community#1420

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@rashedkvm rashedkvm force-pushed the state-reason branch 3 times, most recently from ec3648c to 27197fe Compare February 4, 2026 16:14
sethboyles
sethboyles previously approved these changes Feb 4, 2026
Copy link
Member

@sethboyles sethboyles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'd like someone involved with the RFC to take a look too.

sethboyles
sethboyles previously approved these changes Feb 4, 2026
See RFC#0045 (Stack Management)
Includes state_reason in Stack Validation Error and Warning

Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>

Add Cursor code review rule for Cloud Controller

Adds AI-assisted code review guidelines covering:
- Project architecture patterns (actions, controllers, fetchers)
- Testing requirements (request specs preferred per ADR-0003)
- V3 API compliance (required resource fields)
- Error handling patterns and JSON library usage

ai-assisted=yes

Co-authored-by: Cursor <cursoragent@cursor.com>

Revert "Add Cursor code review rule for Cloud Controller"

This reverts commit 1514fb8.
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
@sethboyles sethboyles merged commit 3a40231 into cloudfoundry:main Feb 9, 2026
25 of 27 checks passed
@rashedkvm rashedkvm deleted the state-reason branch February 9, 2026 22:32
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Feb 9, 2026
Changes in cloud_controller_ng:

- Add state_reason in Stack object
    PR: cloudfoundry/cloud_controller_ng#4823
    Author: Rashed K <89036140+rashedkvm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants