-
Notifications
You must be signed in to change notification settings - Fork 370
Add state_reason in Stack object #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1652721 to
0810cda
Compare
4 tasks
0ba8c46 to
b712ee1
Compare
sethboyles
reviewed
Feb 3, 2026
ec3648c to
27197fe
Compare
sethboyles
previously approved these changes
Feb 4, 2026
Member
sethboyles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I'd like someone involved with the RFC to take a look too.
sethboyles
reviewed
Feb 4, 2026
27197fe to
5c11479
Compare
sethboyles
previously approved these changes
Feb 4, 2026
FloThinksPi
reviewed
Feb 6, 2026
See RFC#0045 (Stack Management) Includes state_reason in Stack Validation Error and Warning Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
d454ba3 to
23cb715
Compare
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com> Add Cursor code review rule for Cloud Controller Adds AI-assisted code review guidelines covering: - Project architecture patterns (actions, controllers, fetchers) - Testing requirements (request specs preferred per ADR-0003) - V3 API compliance (required resource fields) - Error handling patterns and JSON library usage ai-assisted=yes Co-authored-by: Cursor <cursoragent@cursor.com> Revert "Add Cursor code review rule for Cloud Controller" This reverts commit 1514fb8.
Signed-off-by: Rashed Kamal <rashed.kamal@broadcom.com>
1461b2d to
a80289f
Compare
sethboyles
approved these changes
Feb 9, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 9, 2026
Changes in cloud_controller_ng:
- Add state_reason in Stack object
PR: cloudfoundry/cloud_controller_ng#4823
Author: Rashed K <89036140+rashedkvm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Add state_reason in Stack object
An explanation of the use cases your change solves
See RFC#0045 (Stack Management)
Includes state_reason in Stack Validation Error and Warning. See RFC#0045 (Stack Management). Includes state_reason in Stack Validation Error and Warning
Links to any other associated PRs
Enhance stack handling with state_reason field community#1420
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests