Fixes for error propagation#143
Merged
slott56 merged 4 commits intocloud-custodian:mainfrom Dec 25, 2025
Merged
Conversation
Collaborator
Author
|
Need to investigate the lint failure... |
Collaborator
I'm unclear why this isn't passing. It looks like a new lint version is being used and it doesn't like this redundant cast. My suggestion is to fix the failing line: Remove the cast. |
slott56
requested changes
Dec 15, 2025
Collaborator
slott56
left a comment
There was a problem hiding this comment.
These changes look good.
There is an essentially unrelated change required by a lint failure.
See the comments on the PR for the change that needs to be folded into this change.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
@slott56 I'm going to need some help with this — it causes the flow logs test to fail, but I think there's something wrong with the test. Unfortunately, I just don't understand the c7n features well enough to debug it.