This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Fix for Mousetrap to prevent event propagation.#249
Open
destradax wants to merge 3 commits intochieffancypants:masterfrom
Open
Fix for Mousetrap to prevent event propagation.#249destradax wants to merge 3 commits intochieffancypants:masterfrom
destradax wants to merge 3 commits intochieffancypants:masterfrom
Conversation
|
I'd argue this is best left for the user of the library to decide. I always call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when you add combos like Ctrl + a (which is used by some browsers to select everything in the page), the hotkey callback is fired successfully but the event is not cancelled and hence the default action of the combo is executed (Select All in this case)