Open
Conversation
flacoman91
requested review from
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
|
flacoman91
requested review from
anselmbradford
and removed request for
billhimmelsbach,
contolini and
natalia-fitzgerald
Member
|
Neat! But do we have to use Playwright for this, or could we use Cypress? We should probably aim toward having DS/DSR converge with their tech stack as opposed to diverging. Alternatively, we could move the DS to Playwright, though I did explore this back in '23 and ultimately went with Cypress cfpb/design-system#1617 |
Collaborator
Author
|
I can investigate using cypress. We use cypress in ccdb and CE too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have Storybook 10 now, we can do more with it.
I'm not sure if it actually works in the PR preview, but it would be cool if it did!
This PR updates the config to allow in browser tests with vitest and accessibility a11y as well.
yarn install
yarn start
At the bottom left of the browser, just click run tests and you should see them running