fix: [Icon] Restrict wrapper height to match icon height#312
Draft
fix: [Icon] Restrict wrapper height to match icon height#312
Conversation
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #303
This PR eliminates the extra height we were seeing from the
.cf-icon-svg-wrapperelements...but it still doesn't seem to correct the odd alignment issues.Other things I've tried:
.cf-icon-svg'svertical-alignproperty. The only value that seems like it may be an improvement isvertical-align: sub, which shifts icons down 1 or 2 pixels.Changes
How to test this PR
Screenshots
Notes