wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes#278
Draft
shindigira wants to merge 1 commit intomainfrom
Draft
wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes#278shindigira wants to merge 1 commit intomainfrom
shindigira wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
15 tasks
Collaborator
|
Heyo @shindigira! Is this one ready for a review or is still WIP? |
billhimmelsbach
requested changes
Jan 16, 2024
Collaborator
There was a problem hiding this comment.
Heyo @shindigira! I know you're still working on this, but just wanted to let you know that after today's discussions, these three TODOs are going to be fixed at the source in the DS first instead of in the DSR in this PR:
- Change Margin between icon and text to 5px in AlertFieldLevel
- fix the centering icon in Alert (not fieldlevel) (Delay LOW PRIORITY: [context](figma comment that we will revisit this change later))
- Error dotted line around checkbox/textinput
The first two of those TODOs (the margin and centering the icon) will also be de-prioritized and moved to the backlog for now too. Should make this PR a little smaller! 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #276
POSTPONED
Will require a preceding DS approval before a DSR approval.
TODO
Dark hover colors: Text Input - Hover - Define state styling (Success/Warning/Error status) design-system#1881 (comment)
Changes
Screenshots