feat(cli): Implement ability to set Production url#478
Open
leccles1 wants to merge 1 commit intocelest-dev:mainfrom
Open
feat(cli): Implement ability to set Production url#478leccles1 wants to merge 1 commit intocelest-dev:mainfrom
leccles1 wants to merge 1 commit intocelest-dev:mainfrom
Conversation
…plied during celest build or celest start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very basic implementation of including the ability to set a production url during
celest buildandcelest start. As there doesn't appear to be a way to set this outside of runningcelest deploy. Would love to know if it is possible.I haven't touched any tests, tbh the testing setup is very complex and I haven't quite been able to run the full suite yet. Any pointers on that I'd be happy to give it a shot.
Similarly the changes I have made appear to make the most sense to me whilst getting familiar with the repository, but alas, this is quite a large & complex codebase so any feedback, I'm happy to revisit the implementation.
celest buildorcelest start