feat: Add MCP service gRPC client #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MCP service client methods to _rpc/client.py - Add mcp_pb2 imports to gen/__init__.py - Update protobuf generated files for MCP service - Add docs/guides/mcp.md guide - Add integration tests for MCP service - Update API reference and mkdocs nav
There was a problem hiding this comment.
Pull request overview
This pull request adds gRPC client support for the MCP (Model Context Protocol) service, enabling Python SDK users to evaluate tool access (RFC-006) and verify server identity (RFC-007).
Changes:
- Added
MCPClientclass tocapiscio_sdk/_rpc/client.pywith methods for tool access evaluation and server identity verification - Added integration tests in
tests/integration/test_mcp_service.pycovering MCP service functionality - Added comprehensive documentation in
docs/guides/mcp.mdand updateddocs/api-reference.md - Updated protobuf imports in
__init__.pyand regenerated existing pb2 files with newer protobuf version (6.33.4)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
capiscio_sdk/_rpc/client.py |
Added MCPClient class with evaluate_tool_access, verify_server_identity, parse_server_identity_http/jsonrpc, and health methods |
capiscio_sdk/_rpc/gen/capiscio/v1/__init__.py |
Added imports for mcp_pb2 and mcp_pb2_grpc modules |
capiscio_sdk/_rpc/gen/capiscio/v1/*_pb2.py |
Updated protobuf generated files from version 6.33.2 to 6.33.4 |
tests/integration/test_mcp_service.py |
Added comprehensive integration tests for MCP service with 25 test cases covering tool access, server verification, parsing, and error handling |
docs/guides/mcp.md |
Added new MCP security integration guide (521 lines) |
docs/api-reference.md |
Updated API reference to include MCPClient and expanded documentation for other RPC clients |
mkdocs.yml |
Added MCP Security guide to navigation |
- Add Generator return type annotation to start_badge_keeper in badge.py - Add Generator return type annotation to start_keeper in client.py - Fix Google-style docstring format for Yields section - Configure mkdocstrings options for better compatibility
|
✅ Documentation validation passed!
|
These files were ignored by .gitignore but are required for MCP service support.
|
✅ Documentation validation passed!
|
|
✅ All checks passed! Ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The test_mcp_service.py tests require capiscio-core gRPC server running on localhost:50051, which is not set up in the Docker Compose integration test environment. These tests are better suited for E2E testing with full infrastructure.
|
✅ Documentation validation passed!
|
|
✅ All checks passed! Ready for review. |
|
✅ Integration tests passed! Server validation, BadgeKeeper, and gRPC tests all working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds gRPC client support for the MCP service, enabling Python SDK users to generate server keypairs for MCP server identity.
Changes
gRPC Client (
capiscio_sdk/_rpc/client.py)generate_server_keypair()methodgenerate_server_keypair_sync()for synchronous usageMCPKeypairResponsewith public/private keys and DIDGenerated Protobuf (
capiscio_sdk/_rpc/gen/capiscio/v1/)mcp_pb2importsDocumentation
docs/guides/mcp.md- MCP service usage guidedocs/api-reference.mdwith MCP client methodsmkdocs.ymlnavigationTests
tests/integration/test_mcp_service.pyfor MCP service integration testsTesting
Unit tests: 189 passed, 7 pre-existing failures (same as main)
Note: Pre-existing failures in test_agent_card.py, test_certificate.py, test_pop_badge.py exist on main branch.
Dependencies
Related