This repository was archived by the owner on Sep 26, 2022. It is now read-only.
Feat: Support multipart form data with same attribute name#223
Open
quangpdt wants to merge 1 commit intocapacitor-community:mainfrom
Open
Feat: Support multipart form data with same attribute name#223quangpdt wants to merge 1 commit intocapacitor-community:mainfrom
quangpdt wants to merge 1 commit intocapacitor-community:mainfrom
Conversation
Author
|
Hi @thomasvidas , could you please give feedbacks on my PR? It's just a small one and won't take much time to review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading file with
multipart/form-data, there's ability to send the list of value, with same attribute name.Let's have a look on this payload, assuming we're uploading a document with some additional information, these information will be attached into
multipart/form-data. Here's an example of the payload pass from webview to the plugin:What if user want to send a list of
bar, instead only 1 string value?I added the ability to check the type of the value, before adding it to the form data. If it's a string, we'll go ahead as usual. If it's a string array, each item will be added to the form data, with a same name.
See more example of JS implementation at: https://developer.mozilla.org/en-US/docs/Web/API/FormData/append